chore: update librarian version and use list syntax for include_list#5443
chore: update librarian version and use list syntax for include_list#5443
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5443 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 217 217
Lines 48177 48177
=======================================
Hits 47087 47087
Misses 1090 1090 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
In case the CI failures are hard to grok or access: we run |
7e58c8f to
e86dbb6
Compare
a30c0ce to
d84d184
Compare
|
@dbolduc @coryan it seems like the generated diff is failing because showcase was moved to This seems unrelated to my change but I can check to see if there were any expected diffs for Librarian. If that's the case, is the recommended approach to run regenerate? I'll also ask in the Librarian chat to cross-reference. |
At a guess, it was googleapis/librarian#5276
Yeah, we should regenerate. This is the safe way: But if you want to YOLO showcase only, you can do: |
|
If we wanted to be super proper, we would send one PR updating librarian to a commit that flips showcase from |
Me, apparently. I just sent #5445. We should merge that then rebase this PR. |
|
@dbolduc thank you so much for your help and all the PRs!! Appreciate it, especially since I'm ramping up on Librarian and Rust. :) |
No problem, thanks for the update! |
For googleapis/librarian#4298
See googleapis/librarian#5419 as reference for this work
This is PR 2 in this series: googleapis/librarian#4769 (comment)